[ScalarizeShapes] Fold select.int through cat in shape computations#4513
Merged
Conversation
Extend getListFromTensor to recurse into aten.cat operands and add a select.int folding pattern. This resolves shape elements from concat-based shape tensors used by onnx.Reshape lowering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zjgarvey
reviewed
May 7, 2026
Collaborator
zjgarvey
left a comment
zjgarvey
left a comment
There was a problem hiding this comment.
Sorry for the extremely late review. This somehow got dropped from my queue after I went to look back at the prim op. I just have the one concern about the prim op being expected to return rank 0 sometimes, but otherwise this looks good to me.
…eplacement Address review: prim.NumToTensor.Scalar's abstract-interp shape function returns []. Constructing it with a non-rank-0 result type (as it would be when aten.select.int produces a [1] tensor in ONNX->Torch lowering) leaves its SSA type inconsistent with the shape contract. Build the NumToTensor with an explicit rank-0 type. When the original select.int result is non-rank-0, recover the shape via aten.unsqueeze. getListFromTensor already pattern-matches unsqueeze(NumToTensor(scalar)), so downstream propagation patterns still see straight through; the helper + RemoveUnusedPattern entries reclaim the intermediates after item folds. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jtuyls
force-pushed
the
shape-gather-to-size-int
branch
from
0365566 to
21dc832
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend getListFromTensor to recurse into aten.cat operands and add a select.int folding pattern. This resolves shape elements from concat-based shape tensors used by onnx.Reshape lowering.